Fix WorldBank urls and outdated data usage#1292
Open
spjuhel wants to merge 19 commits into
Open
Conversation
This was
linked to
issues
May 15, 2026
* Fix TCTracks.from_FAST duplicate loading from year loop * Refactor test_from_FAST: extend fixture to 2 years, remove separate regression test The test fixture FAST_test_tracks.nc now has year=[2025,2026] (only seeds_per_month is extended; track variables retain their n_trk dim). The existing len(tc_track.data)==5 assertion now acts as the regression check: the buggy year-loop code would return 5x2=10 tracks. The separate test_from_FAST_not_multiplied_by_year_dim (with its temporary-file scaffolding) is removed. * Update changelo --------- Co-authored-by: Simona Meiler <simona.meiler@usys.ethz.ch> Co-authored-by: Chahan Kropf <chahan.kropf@posteo.com>
spjuhel
changed the title
spjuhel
requested review from
chahank,
emanuel-schmid and
peanutfun
as code owners
Collaborator
Author
|
@emanuel-schmid or @peanutfun, this should be a quick one to review. And will fix some of the currently failing tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
This PR fixes #1291 and #1293
PR Author Checklist
develop)PR Reviewer Checklist